[
https://issues.apache.org/jira/browse/HIVE-25938?focusedWorklogId=725275&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-725275
]
ASF GitHub Bot logged work on HIVE-25938:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Feb/22 16:57
Start Date: 11/Feb/22 16:57
Worklog Time Spent: 10m
Work Description: asolimando commented on a change in pull request #3011:
URL: https://github.com/apache/hive/pull/3011#discussion_r804838326
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java
##########
@@ -2026,6 +2038,8 @@ protected RelNode
applyMaterializedViewRewriting(RelOptPlanner planner, RelNode
// Optimize plan
if (!ruleExclusionRegex.isEmpty()) {
+ LOG.debug("The CBO rules matching the following regex are excluded
from planning: {}",
Review comment:
I think this is a very valid point, and this property should not be on
apart from very edge cases, so I don't think it will clog the output much. Let
me move from debug to info as you suggest!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 725275)
Time Spent: 1h (was: 50m)
> Print excluded rules from CBO
> -----------------------------
>
> Key: HIVE-25938
> URL: https://issues.apache.org/jira/browse/HIVE-25938
> Project: Hive
> Issue Type: Improvement
> Components: CBO
> Affects Versions: 4.0.0
> Reporter: Alessandro Solimando
> Assignee: Alessandro Solimando
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> HIVE-25880 introduced a configuration parameter for excluding CBO rules based
> on a regex on their description.
> Calcite logs when a rule is excluded (see
> [AbstractRelOptPlanner.java#L316|https://github.com/apache/calcite/blob/e42b85a45bd16dd58db1546736e653deda5463fe/core/src/main/java/org/apache/calcite/plan/AbstractRelOptPlanner.java#L316]
> and
> [VolcanoRuleCall.java#L169|https://github.com/apache/calcite/blob/e42b85a45bd16dd58db1546736e653deda5463fe/core/src/main/java/org/apache/calcite/plan/volcano/VolcanoRuleCall.java#L169]).
> To ease investigations, this should be complemented by printing the regex
> used (if not blank) in Hive DEBUG logs, and the same in CBO information
> (i.e., EXPLAIN CBO's output).
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
