[
https://issues.apache.org/jira/browse/HIVE-25897?focusedWorklogId=715734&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-715734
]
ASF GitHub Bot logged work on HIVE-25897:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Jan/22 14:55
Start Date: 26/Jan/22 14:55
Worklog Time Spent: 10m
Work Description: lcspinter commented on a change in pull request #2973:
URL: https://github.com/apache/hive/pull/2973#discussion_r792720421
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Cleaner.java
##########
@@ -429,7 +422,8 @@ private boolean removeFiles(String location,
ValidWriteIdList writeIdList, Compa
.map(Path::getName).collect(Collectors.joining(",")));
boolean success = remove(location, ci, obsoleteDirs, true, fs,
extraDebugInfo);
if (dir.getObsolete().size() > 0) {
- updateDeltaFilesMetrics(ci.dbname, ci.tableName, ci.partName,
dir.getObsolete());
+ AcidMetricService.updateMetricsFromCleaner(ci.dbname, ci.tableName,
ci.partName, dir.getObsolete(), conf,
Review comment:
You're right. Fixed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 715734)
Time Spent: 40m (was: 0.5h)
> Move delta metric collection into AcidMetricsService
> ----------------------------------------------------
>
> Key: HIVE-25897
> URL: https://issues.apache.org/jira/browse/HIVE-25897
> Project: Hive
> Issue Type: Improvement
> Reporter: László Pintér
> Assignee: László Pintér
> Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> DeltaFilesMetricReporter and AcidMetricsService are two different threads
> collecting ACID related metrics. It makes sense to merge those threads since
> they share the same goal.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
