[ 
https://issues.apache.org/jira/browse/HIVE-25880?focusedWorklogId=712126&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-712126
 ]

ASF GitHub Bot logged work on HIVE-25880:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 20/Jan/22 14:58
            Start Date: 20/Jan/22 14:58
    Worklog Time Spent: 10m 
      Work Description: zabetak commented on a change in pull request #2955:
URL: https://github.com/apache/hive/pull/2955#discussion_r788846909



##########
File path: common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
##########
@@ -1883,6 +1883,8 @@ private static void populateLlapDaemonVarsSet(Set<String> 
llapDaemonVarsSetLocal
                                                                  + " expressed 
as multiple of Local FS write cost"),
     HIVE_CBO_COST_MODEL_HDFS_READ("hive.cbo.costmodel.hdfs.read", "1.5", 
"Default cost of reading a byte from HDFS;"
                                                                  + " expressed 
as multiple of Local FS read cost"),
+    HIVE_CBO_RULE_EXCLUSION_REGEX("hive.cbo.rule.exclusion.regex", "",

Review comment:
       Great ;)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 712126)
    Time Spent: 1h  (was: 50m)

> Add configuration option to exclude rules by a regex on their description
> -------------------------------------------------------------------------
>
>                 Key: HIVE-25880
>                 URL: https://issues.apache.org/jira/browse/HIVE-25880
>             Project: Hive
>          Issue Type: New Feature
>          Components: CBO
>    Affects Versions: 4.0.0
>            Reporter: Alessandro Solimando
>            Assignee: Alessandro Solimando
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> Introduce a configuration option to exclude rules via a regex on the rule 
> description, based on Calcite's 
> [org.apache.calcite.plan.AbstractRelOptPlanner#setRuleDescExclusionFilter|https://github.com/apache/calcite/blob/0065d7c179b98698f018f83b0af0845a6698fc54/core/src/main/java/org/apache/calcite/plan/AbstractRelOptPlanner.java#L186].
> The motivation is to provide a quick workaround when one or more rules are 
> causing issues at planning time, without code changes.
> Another use would be to quickly experiment on the impact of disabling one or 
> more rules on the compute plan.
> An example of configuration would be as follows:
> {code:java}
> set 
> hive.cbo.rule.exclusion.regex=HiveJoinPushTransitivePredicatesRule|HivePreFilteringRule;
> {code}
> The above configuration setting would exclude from planning both 
> _HiveJoinPushTransitivePredicatesRule_ and _HivePreFilteringRule_ rules.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to