[
https://issues.apache.org/jira/browse/HIVE-25667?focusedWorklogId=709663&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-709663
]
ASF GitHub Bot logged work on HIVE-25667:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Jan/22 20:14
Start Date: 16/Jan/22 20:14
Worklog Time Spent: 10m
Work Description: mbathori-cloudera commented on pull request #2919:
URL: https://github.com/apache/hive/pull/2919#issuecomment-1013944369
@zabetak Thanks for reviewing my changes. I made a new commit where I tried
to address all of your comments.
- I moved the common database classes to the `hive-testutils` module.
- Moved metastore related parts from common database classes to a wrapper
class in the metastore.
- Removed the `ExternalResource` and refactored depending functions.
**_Some note for the hive-testutil pom changes:_**
I had a strange issue while adding `hive-testutils` to the
`itests/util/pom.xml`. The qtests were not executed and the build automatically
skipped all of them without any error message. It turned out that a dependency
called `junit-jupiter-api` caused this issue. If I set this dependency to test
scope the problem would be solved but I can’t do it because classes that are
using it are placed in the src package. The easiest solution was to set the
dependency to _optional_ so it will be excluded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 709663)
Time Spent: 2h (was: 1h 50m)
> Unify code managing JDBC databases in tests
> -------------------------------------------
>
> Key: HIVE-25667
> URL: https://issues.apache.org/jira/browse/HIVE-25667
> Project: Hive
> Issue Type: Task
> Components: Testing Infrastructure
> Affects Versions: 4.0.0
> Reporter: Stamatis Zampetakis
> Assignee: Mark Bathori
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h
> Remaining Estimate: 0h
>
> Currently there are two class hierarchies managing JDBC databases in tests,
> [DatabaseRule|https://github.com/apache/hive/blob/d35de014dd49fdcfe0aacb68e6c587beff6d1dea/standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/dbinstall/rules/DatabaseRule.java]
> and
> [AbstractExternalDB|https://github.com/apache/hive/blob/d35de014dd49fdcfe0aacb68e6c587beff6d1dea/itests/util/src/main/java/org/apache/hadoop/hive/ql/externalDB/AbstractExternalDB.java].
> There are many similarities between these hierarchies and certain parts are
> duplicated.
> The goal of this JIRA is to refactor the aforementioned hierarchies to reduce
> code duplication and improve extensibility.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
