[
https://issues.apache.org/jira/browse/HIVE-25862?focusedWorklogId=708211&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-708211
]
ASF GitHub Bot logged work on HIVE-25862:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Jan/22 10:47
Start Date: 13/Jan/22 10:47
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on a change in pull request #2945:
URL: https://github.com/apache/hive/pull/2945#discussion_r783841367
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java
##########
@@ -5998,7 +5998,8 @@ private void acquireTxnLock(Statement stmt, boolean
shared) throws SQLException,
private final Statement stmt;
private final ResultSet rs;
private final Semaphore derbySemaphore;
- private final List<String> keys = new ArrayList<>();
+ private final String key1;
Review comment:
can we define key + lastUpdateTime and initialize them in the
constructor?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 708211)
Time Spent: 50m (was: 40m)
> Persist the time of last run of the initiator
> ---------------------------------------------
>
> Key: HIVE-25862
> URL: https://issues.apache.org/jira/browse/HIVE-25862
> Project: Hive
> Issue Type: Improvement
> Reporter: Antal Sinkovits
> Assignee: Antal Sinkovits
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> The time of last run is used as a filter when finding compaction candidates.
> Because its only stored in memory, we lose this filtering capability if the
> service restarts, so it would make sense to persist it.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
