[
https://issues.apache.org/jira/browse/HIVE-25667?focusedWorklogId=703452&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-703452
]
ASF GitHub Bot logged work on HIVE-25667:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Jan/22 17:54
Start Date: 04/Jan/22 17:54
Worklog Time Spent: 10m
Work Description: mbathori-cloudera opened a new pull request #2919:
URL: https://github.com/apache/hive/pull/2919
### What changes were proposed in this pull request?
Currently there are two class hierarchies managing JDBC databases in tests,
DatabaseRule and AbstractExternalDB. These changes meant to unify these
database related functionalities and get rid of the duplicated codes.
### Why are the changes needed?
The current solution is redundant, contains a lot of code duplications. The
unified database handling gives easier extensibility and modification.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
All the previous tests that were covering the affected database
functionality are passing with the same expected results.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 703452)
Remaining Estimate: 0h
Time Spent: 10m
> Unify code managing JDBC databases in tests
> -------------------------------------------
>
> Key: HIVE-25667
> URL: https://issues.apache.org/jira/browse/HIVE-25667
> Project: Hive
> Issue Type: Task
> Components: Testing Infrastructure
> Affects Versions: 4.0.0
> Reporter: Stamatis Zampetakis
> Assignee: Mark Bathori
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently there are two class hierarchies managing JDBC databases in tests,
> [DatabaseRule|https://github.com/apache/hive/blob/d35de014dd49fdcfe0aacb68e6c587beff6d1dea/standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/dbinstall/rules/DatabaseRule.java]
> and
> [AbstractExternalDB|https://github.com/apache/hive/blob/d35de014dd49fdcfe0aacb68e6c587beff6d1dea/itests/util/src/main/java/org/apache/hadoop/hive/ql/externalDB/AbstractExternalDB.java].
> There are many similarities between these hierarchies and certain parts are
> duplicated.
> The goal of this JIRA is to refactor the aforementioned hierarchies to reduce
> code duplication and improve extensibility.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
