[
https://issues.apache.org/jira/browse/HIVE-25822?focusedWorklogId=698799&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-698799
]
ASF GitHub Bot logged work on HIVE-25822:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Dec/21 16:05
Start Date: 20/Dec/21 16:05
Worklog Time Spent: 10m
Work Description: amansinha100 commented on a change in pull request
#2891:
URL: https://github.com/apache/hive/pull/2891#discussion_r772487246
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/exec/CommonMergeJoinOperator.java
##########
@@ -240,6 +249,17 @@ public void process(Object row, int tag) throws
HiveException {
byte alias = (byte) tag;
List<Object> value = getFilteredValue(alias, row);
+
+ if (shortcutExtensionRows && isOuterJoinExtensionRow(tag, value)) {
+ int type = condn[0].getType();
+ if (tag == 0 && (type == JoinDesc.LEFT_OUTER_JOIN || type ==
JoinDesc.FULL_OUTER_JOIN)) {
+ emitExtensionRow(tag, value);
Review comment:
I applied this patch and added a log message to emitExtensionRow() and
ran queries with full , left and right outer join (with the extra single table
predicate in ON clause) but only see the log msg for full outer join, not for
left/right. It is unclear which situations would lead to extension rows for
left/right outer join.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 698799)
Time Spent: 1.5h (was: 1h 20m)
> Incorrect False positive result rows may be outputted in case outer join has
> conditions only affecting one side
> ---------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-25822
> URL: https://issues.apache.org/jira/browse/HIVE-25822
> Project: Hive
> Issue Type: Bug
> Reporter: Zoltan Haindrich
> Assignee: Zoltan Haindrich
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> needed
> * outer join
> * on condition has at least one condition for one side of the join
> * in a single reducer:
> ** a right hand side only row outputted right before
> ** >=2 rows on LHS and 1 on RHS matching in the join keys but the first LHS
> doesn't satisfies the filter condition
> ** second LHS row with good filter condition
> {code}
> with
> t_y as (select col1 as id,col2 as s from (VALUES(0,'a'),(1,'y')) as c),
> t_xy as (select col1 as id,col2 as s from (VALUES(1,'x'),(1,'y')) as c)
> select * from t_xy l full outer join t_y r on (l.id=r.id and l.s='y');
> {code}
> null,null,1,y is a false positive result
> {code}
> +-------+-------+-------+-------+
> | l.id | l.s | r.id | r.s |
> +-------+-------+-------+-------+
> | NULL | NULL | 0 | a |
> | 1 | x | NULL | NULL |
> | NULL | NULL | 1 | y |
> | 1 | y | 1 | y |
> +-------+-------+-------+-------+
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
