[
https://issues.apache.org/jira/browse/HIVE-25792?focusedWorklogId=696781&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-696781
]
ASF GitHub Bot logged work on HIVE-25792:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Dec/21 17:50
Start Date: 15/Dec/21 17:50
Worklog Time Spent: 10m
Work Description: zabetak commented on a change in pull request #2865:
URL: https://github.com/apache/hive/pull/2865#discussion_r769857181
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java
##########
@@ -673,8 +672,7 @@ Operator genOPTree(ASTNode ast, PlannerContext plannerCtx)
throws SemanticExcept
}
this.ctx.setCboInfo(cboMsg);
- // Determine if we should re-throw the exception OR if we try to
mark plan as reAnalyzeAST to retry
- // planning as non-CBO.
+ // Determine if we should re-throw the exception OR if we try to
mark the query to retry as non-CBO.
Review comment:
Interesting, I was about to comment that `ReCompileException` should
better be `CBOException` :) It really feels that this is a better approach.
If we review this part of the code independently of what happens elsewhere
it seems reasonable that we are catching an exception and wrapping it around
another more "high-level" abstraction. This is usually a good coding pattern.
Apart from that, I don't know if it is crucial to retain exactly the same
outputs in tests. For instance, if the changes you mention are due to the
following part of the code:
```
// Wrap all other errors (Should only hit in tests)
throw new SemanticException(e);
```
then it makes believe even more that we shouldn't care.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 696781)
Time Spent: 5h 20m (was: 5h 10m)
> Multi Insert query fails on CBO path
> -------------------------------------
>
> Key: HIVE-25792
> URL: https://issues.apache.org/jira/browse/HIVE-25792
> Project: Hive
> Issue Type: Bug
> Reporter: Zoltan Haindrich
> Assignee: Peter Vary
> Priority: Major
> Labels: pull-request-available
> Time Spent: 5h 20m
> Remaining Estimate: 0h
>
> {code}
> set hive.cbo.enable=true;
> drop table if exists aa1;
> drop table if exists bb1;
> drop table if exists cc1;
> drop table if exists dd1;
> drop table if exists ee1;
> drop table if exists ff1;
> create table aa1 ( stf_id string);
> create table bb1 ( stf_id string);
> create table cc1 ( stf_id string);
> create table ff1 ( x string);
> explain
> from ff1 as a join cc1 as b
> insert overwrite table aa1 select stf_id GROUP BY b.stf_id
> insert overwrite table bb1 select b.stf_id GROUP BY b.stf_id
> ;
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
