[ 
https://issues.apache.org/jira/browse/HIVE-12080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14966129#comment-14966129
 ] 

Mohammad Kamrul Islam commented on HIVE-12080:
----------------------------------------------

[~spena] : my comments:
1. DataWritableReadSupport is instantiated and later called prepareForRead() 
from InternalParquetReader class that comes with parquet library. This class is 
passed in class MapredParquetInputFormat. Yes it is confusing :)

2. Added more test cases and with a new file name.

4. I also thought of other types. We can start with this common type and can 
extend to those in a separate JIRA.
 

Thanks again for the review. Also put the patch into review board.

> Support auto type widening for Parquet table
> --------------------------------------------
>
>                 Key: HIVE-12080
>                 URL: https://issues.apache.org/jira/browse/HIVE-12080
>             Project: Hive
>          Issue Type: New Feature
>          Components: File Formats
>            Reporter: Mohammad Kamrul Islam
>            Assignee: Mohammad Kamrul Islam
>         Attachments: HIVE-12080.1.patch
>
>
> Currently Hive+Parquet doesn't support it. It should include at least basic 
> type promotions short->int->bigint,  float->double etc, that are already 
> supported for  other file formats.
> There were similar effort (Hive-6784) but was not committed. This JIRA is to 
> address the same in different way with little (no) performance impact.
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to