[ https://issues.apache.org/jira/browse/HIVE-25623?focusedWorklogId=689284&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-689284 ]
ASF GitHub Bot logged work on HIVE-25623: ----------------------------------------- Author: ASF GitHub Bot Created on: 02/Dec/21 13:35 Start Date: 02/Dec/21 13:35 Worklog Time Spent: 10m Work Description: mbathori-cloudera opened a new pull request #2835: URL: https://github.com/apache/hive/pull/2835 ### What changes were proposed in this pull request? Make the DbTxnManager based tests parameterized and running them both with enabled and disabled TXN_USE_MIN_HISTORY_LEVEL. I also modified the 'setup' function to set back the HiveConf to default value before every test run since there were some tests e.g. 'testFullTableReadLock' that made changes in the configuration and didn't reset them so it affected other tests. ### Why are the changes needed? Cover the disabled TXN_USE_MIN_HISTORY_LEVEL functionality with tests. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Locally run the tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 689284) Remaining Estimate: 0h Time Spent: 10m > Create a parametrized test to check against the disabled MIN_HISTORY config > --------------------------------------------------------------------------- > > Key: HIVE-25623 > URL: https://issues.apache.org/jira/browse/HIVE-25623 > Project: Hive > Issue Type: Task > Reporter: Denys Kuzmenko > Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > Currently all test cases in TestDbTxnManager2/TestCommands(X) run against > enabled MIN_HISTORY config. We should also execute them for the scenario when > MIN_HISTORY_LEVEL table is missing. -- This message was sent by Atlassian Jira (v8.20.1#820001)