[
https://issues.apache.org/jira/browse/HIVE-25652?focusedWorklogId=687439&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-687439
]
ASF GitHub Bot logged work on HIVE-25652:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Nov/21 16:58
Start Date: 29/Nov/21 16:58
Worklog Time Spent: 10m
Work Description: soumyakanti3578 commented on a change in pull request
#2777:
URL: https://github.com/apache/hive/pull/2777#discussion_r758558430
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/metadata/CheckConstraint.java
##########
@@ -34,13 +34,40 @@
@SuppressWarnings("serial")
public class CheckConstraint implements Serializable {
- public class CheckConstraintCol {
- public String colName;
- public String checkExpression;
-
- public CheckConstraintCol(String colName, String checkExpression) {
+ public static class CheckConstraintCol {
+ private final String colName;
+ private final String checkExpression;
+ private final String enable;
+ private final String validate;
+ private final String rely;
Review comment:
I think we should keep them as `String` becasue:
1. we can get the boolean values using `constraint.isEnable_cstr()` anyway.
2. We are setting them to String values based on its boolean values
[here](https://github.com/apache/hive/pull/2777/files/3c667cfa85e41f5c7377aa0f606b3d1fe7c467e5#diff-adcaf114fc9b04e43b9004e5464e588a85022712a79b3592d374fb69e8d1f8bdR98),
which helps while printing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 687439)
Time Spent: 3h 10m (was: 3h)
> Add constraints in result of “SHOW CREATE TABLE ”
> -------------------------------------------------
>
> Key: HIVE-25652
> URL: https://issues.apache.org/jira/browse/HIVE-25652
> Project: Hive
> Issue Type: Improvement
> Reporter: Soumyakanti Das
> Assignee: Soumyakanti Das
> Priority: Major
> Labels: pull-request-available
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> Currently show create table doesn’t pull any constraint info like not null,
> defaults, primary key.
> Example:
> Create table
>
> {code:java}
> CREATE TABLE TEST(
> col1 varchar(100) NOT NULL COMMENT "comment for column 1",
> col2 timestamp DEFAULT CURRENT_TIMESTAMP() COMMENT "comment for column 2",
> col3 decimal,
> col4 varchar(512) NOT NULL,
> col5 varchar(100),
> primary key(col1, col2) disable novalidate)
> ROW FORMAT SERDE
> 'org.apache.hadoop.hive.ql.io.orc.OrcSerde'
> STORED AS INPUTFORMAT
> 'org.apache.hadoop.hive.ql.io.orc.OrcInputFormat'
> OUTPUTFORMAT
> 'org.apache.hadoop.hive.ql.io.orc.OrcOutputFormat';
> {code}
> Currently {{SHOW CREATE TABLE TEST}} doesn't show the column constraints.
> {code:java}
> CREATE TABLE `test`(
> `col1` varchar(100) COMMENT 'comment for column 1',
> `col2` timestamp COMMENT 'comment for column 2',
> `col3` decimal(10,0),
> `col4` varchar(512),
> `col5` varchar(100))
> ROW FORMAT SERDE
> 'org.apache.hadoop.hive.ql.io.orc.OrcSerde'
> STORED AS INPUTFORMAT
> 'org.apache.hadoop.hive.ql.io.orc.OrcInputFormat'
> OUTPUTFORMAT
> 'org.apache.hadoop.hive.ql.io.orc.OrcOutputFormat'
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
