[
https://issues.apache.org/jira/browse/HIVE-25740?focusedWorklogId=687282&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-687282
]
ASF GitHub Bot logged work on HIVE-25740:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Nov/21 12:13
Start Date: 29/Nov/21 12:13
Worklog Time Spent: 10m
Work Description: marton-bod commented on a change in pull request #2817:
URL: https://github.com/apache/hive/pull/2817#discussion_r758304580
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java
##########
@@ -748,6 +736,7 @@ void wasSuccessful() {
* @throws Exception
*/
@Override public void close() throws Exception {
+ shutdownHeartbeater();
Review comment:
As discussed, I've introduced a flag in the heartbeater thread to turn
on/off error logging. The new order is now:
- turn off heartbeater error logging
- commit/abort txn
- shut down heartbeater
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 687282)
Time Spent: 40m (was: 0.5h)
> Handle race condition between compaction txn abort/commit and heartbeater
> -------------------------------------------------------------------------
>
> Key: HIVE-25740
> URL: https://issues.apache.org/jira/browse/HIVE-25740
> Project: Hive
> Issue Type: Bug
> Reporter: Marton Bod
> Assignee: Marton Bod
> Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> This issue is the following: once the compaction worker finishes,
> commitTxn/abortTxn is invoked first, and the heartbeater thread is only
> interrupted after that. This can lead to race conditions where the txn has
> already been deleted from the backend DB via commit/abort, but the
> concurrently running heartbeater thread still attempts to send a last
> heartbeat after that, but the txn id won't be found in the DB, leading to
> {{{}NoSuchTxnException{}}}.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
