[
https://issues.apache.org/jira/browse/HIVE-25670?focusedWorklogId=680320&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-680320
]
ASF GitHub Bot logged work on HIVE-25670:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Nov/21 15:34
Start Date: 11/Nov/21 15:34
Worklog Time Spent: 10m
Work Description: scarlin-cloudera commented on a change in pull request
#2763:
URL: https://github.com/apache/hive/pull/2763#discussion_r747601749
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/RelOptHiveTable.java
##########
@@ -333,12 +360,20 @@ public boolean isKey(ImmutableBitSet columns) {
parentTableQualifiedName.add(parentTableName);
qualifiedName = parentTableName;
}
+ if (!tablesCache.containsKey(qualifiedName)) {
+ // Table doesn't exist in the cache, so we don't need to track
+ // these referential constraints. But we do need to keep track
+ // of the table in case the tableCache gets populated later, though
+ // in theory, this should never happen based on how this is called.
Review comment:
Ok, in my most recent push, I created a hash map wrapper. This wrapper
allows the caller to mark the fact that all tables have been parsed.
The call for getting the referential constraints is now only allowed when
the table map is marked as parsed so we can be assured that the list of tables
used in the query is complete when fetching the referential constraints. I
think I did this with minimal intrusion on the original code, though some of
that still does need rewriting.
Thanks for the review comments and making me think about this a bit more!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 680320)
Time Spent: 1h 10m (was: 1h)
> Avoid getTable() calls for foreign key tables not used in a query
> -----------------------------------------------------------------
>
> Key: HIVE-25670
> URL: https://issues.apache.org/jira/browse/HIVE-25670
> Project: Hive
> Issue Type: Improvement
> Components: HiveServer2
> Reporter: Steve Carlin
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> In RelOptHiveTable, we generate the referential constraints for the table. In
> this process, we make a metastore call to fetch these tables. This is used
> later on for potential gain on joins done on the key.
> However, there is no need to fetch these constraints if the table is not used
> in the query. If we can get this information up front, we can save a bit on
> compilation time.
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
