[
https://issues.apache.org/jira/browse/HIVE-25631?focusedWorklogId=679014&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-679014
]
ASF GitHub Bot logged work on HIVE-25631:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Nov/21 12:49
Start Date: 09/Nov/21 12:49
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on a change in pull request #2741:
URL: https://github.com/apache/hive/pull/2741#discussion_r745583998
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java
##########
@@ -508,14 +540,6 @@ private boolean isEligibleForCompaction(CompactionInfo ci,
return false;
}
- if (txnHandler.checkFailedCompactions(ci)) {
Review comment:
It's a public API, could be used by an external application, so not safe
to remove.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 679014)
Time Spent: 40m (was: 0.5h)
> Initiator speed-up: only read compaction history once per loop
> --------------------------------------------------------------
>
> Key: HIVE-25631
> URL: https://issues.apache.org/jira/browse/HIVE-25631
> Project: Hive
> Issue Type: Task
> Reporter: Denys Kuzmenko
> Assignee: Denys Kuzmenko
> Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> In checkFailedCompactions (which is called for every partition in the list of
> potentials to compact) we select from metadata table COMPLETED_COMPACTIONS.
> But the Initiator main loop already has a ShowCompactResponse. We can use
> that instead.
> For cases where metadata is huge, this will help speed up the Initiator.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
