[
https://issues.apache.org/jira/browse/HIVE-25596?focusedWorklogId=676237&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-676237
]
ASF GitHub Bot logged work on HIVE-25596:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Nov/21 07:25
Start Date: 04/Nov/21 07:25
Worklog Time Spent: 10m
Work Description: pkumarsinha commented on a change in pull request #2724:
URL: https://github.com/apache/hive/pull/2724#discussion_r742587970
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/parse/repl/metric/ReplicationMetricCollector.java
##########
@@ -116,14 +136,16 @@ public void reportStageEnd(String stageName, Status
status, long lastReplId,
stage = new Stage(stageName, status, -1L);
}
stage.setStatus(status);
- stage.setEndTime(System.currentTimeMillis());
+ stage.setEndTime(getCurrentTimeInMillis());
stage.setReplSnapshotsCount(replSnapshotCount);
if (replStatsTracker != null && !(replStatsTracker instanceof
NoOpReplStatsTracker)) {
String replStatString = replStatsTracker.toString();
LOG.info("Replication Statistics are: {}", replStatString);
stage.setReplStats(replStatString);
}
progress.addStage(stage);
+ // Check the progress string doesn't surpass the RM_PROGRESS column
width.
+ checkRMProgressLimit(progress, stage);
Review comment:
nit:
it's not just check. it is updating the state as well. we should name it
accordingly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 676237)
Time Spent: 5h 10m (was: 5h)
> Compress Hive Replication Metrics while storing
> -----------------------------------------------
>
> Key: HIVE-25596
> URL: https://issues.apache.org/jira/browse/HIVE-25596
> Project: Hive
> Issue Type: Improvement
> Reporter: Haymant Mangla
> Assignee: Haymant Mangla
> Priority: Major
> Labels: pull-request-available
> Attachments: CompressedRM_Progress(k=10), CompressedRM_Progress(k=5),
> PlainTextRM_Progress(k=10), PlainTextRM_Progress(k=5)
>
> Time Spent: 5h 10m
> Remaining Estimate: 0h
>
> Compress the json fields of sys.replication_metrics table to optimise RDBMS
> space usage.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
