[ 
https://issues.apache.org/jira/browse/HIVE-25625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stamatis Zampetakis resolved HIVE-25625.
----------------------------------------
    Fix Version/s: 4.0.0
       Resolution: Fixed

Fixed in 
[afeb0f8413b1fd777611e890e53925119a5e39f1|https://github.com/apache/hive/commit/afeb0f8413b1fd777611e890e53925119a5e39f1].
 Thanks for the review and fruitful discussions [~kgyrtkirk]!

> Drop TestCompareCliDriver and related code from tests
> -----------------------------------------------------
>
>                 Key: HIVE-25625
>                 URL: https://issues.apache.org/jira/browse/HIVE-25625
>             Project: Hive
>          Issue Type: Task
>          Components: Testing Infrastructure
>            Reporter: Stamatis Zampetakis
>            Assignee: Stamatis Zampetakis
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 4.0.0
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> The driver has been introduced back in 2015 (HIVE-6010) aiming to run queries 
> with vectorization on/off and comparing the results. However it didn't 
> receive much attention since then and currently only two queries are run with 
> this driver.
> The majority of tests aiming to ensure vectorization works correctly use the 
> {{TestMiniLlapLocalCliDriver}} and run a query twice switching on/off the 
> necessary properties.
> Summing up having the 
> [TestCompareCliDriver|https://github.com/apache/hive/blob/d521f149fade25f74e7ca28fa399103684a80580/itests/qtest/src/test/java/org/apache/hadoop/hive/cli/TestCompareCliDriver.java]
>  in the repo leads to extra code maintenance cost without significant benefit.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to