[
https://issues.apache.org/jira/browse/HIVE-25346?focusedWorklogId=666301&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-666301
]
ASF GitHub Bot logged work on HIVE-25346:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Oct/21 13:52
Start Date: 18/Oct/21 13:52
Worklog Time Spent: 10m
Work Description: pvary commented on a change in pull request #2716:
URL: https://github.com/apache/hive/pull/2716#discussion_r730944209
##########
File path:
ql/src/test/org/apache/hadoop/hive/ql/lockmgr/DbTxnManagerEndToEndTestBase.java
##########
@@ -64,7 +65,8 @@ public void setUp() throws Exception {
ctx = new Context(conf);
driver = new Driver(new
QueryState.Builder().withHiveConf(conf).nonIsolated().build());
driver2 = new Driver(new QueryState.Builder().withHiveConf(conf).build());
- conf.setBoolVar(HiveConf.ConfVars.TXN_WRITE_X_LOCK, false);
+ HiveConf.setBoolVar(conf, HiveConf.ConfVars.TXN_WRITE_X_LOCK, false);
+ MetastoreConf.setBoolVar(conf,
MetastoreConf.ConfVars.TXN_USE_MIN_HISTORY_LEVEL, true);
Review comment:
Shall we use this new config instead of the
`TxnHandler.useMinHistoryLevel` then? I would hate to have two different
methods to handle this config. Also If in the future we would like to make sure
that this config is changed in several connected deployments together, it would
be good to need to change it only a single well defined place
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 666301)
Time Spent: 10h 10m (was: 10h)
> cleanTxnToWriteIdTable breaks SNAPSHOT isolation
> ------------------------------------------------
>
> Key: HIVE-25346
> URL: https://issues.apache.org/jira/browse/HIVE-25346
> Project: Hive
> Issue Type: Bug
> Reporter: Zoltan Chovan
> Assignee: Zoltan Chovan
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
