[ https://issues.apache.org/jira/browse/HIVE-25520?focusedWorklogId=661111&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-661111 ]
ASF GitHub Bot logged work on HIVE-25520: ----------------------------------------- Author: ASF GitHub Bot Created on: 06/Oct/21 18:02 Start Date: 06/Oct/21 18:02 Worklog Time Spent: 10m Work Description: pgaref commented on a change in pull request #2640: URL: https://github.com/apache/hive/pull/2640#discussion_r723552123 ########## File path: ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/concatenate/AlterTableConcatenateAnalyzer.java ########## @@ -73,13 +73,19 @@ protected void analyzeCommand(TableName tableName, Map<String, String> partition if (AcidUtils.isTransactionalTable(table)) { compactAcidTable(tableName, partitionSpec); } else { + // non-native and non-managed tables are not supported as MoveTask requires filenames to be in specific format, // violating which can cause data loss if (table.isNonNative()) { throw new SemanticException(ErrorMsg.CONCATENATE_UNSUPPORTED_TABLE_NON_NATIVE.getMsg()); } + if (table.getTableType() != TableType.MANAGED_TABLE) { - throw new SemanticException(ErrorMsg.CONCATENATE_UNSUPPORTED_TABLE_NOT_MANAGED.getMsg()); + // Enable concatenate for external tables if config is set. + if (!conf.getBoolVar(ConfVars.ENABLE_CONCATENATE_FOR_EXTERNAL_TABLES) Review comment: Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 661111) Time Spent: 40m (was: 0.5h) > Enable concatenate for external table. > -------------------------------------- > > Key: HIVE-25520 > URL: https://issues.apache.org/jira/browse/HIVE-25520 > Project: Hive > Issue Type: Improvement > Components: HiveServer2 > Reporter: Harish JP > Assignee: Harish JP > Priority: Major > Labels: pull-request-available > Time Spent: 40m > Remaining Estimate: 0h > > Concatenate for external tables are disabled, enable this under a flag. -- This message was sent by Atlassian Jira (v8.3.4#803005)