[ https://issues.apache.org/jira/browse/HIVE-23633?focusedWorklogId=659379&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-659379 ]
ASF GitHub Bot logged work on HIVE-23633: ----------------------------------------- Author: ASF GitHub Bot Created on: 04/Oct/21 00:32 Start Date: 04/Oct/21 00:32 Worklog Time Spent: 10m Work Description: dengzhhu653 commented on pull request #2344: URL: https://github.com/apache/hive/pull/2344#issuecomment-933060720 > > Hi @pvary, cloud you help merge this? thank you! :) > > Ahh... Sorry for forgetting about this review. Could you please ping @belugabehr to check if he is OK with the current solution? > > Also we will need to rebase / rerun the tests. I see that theoretically it can be merged without a conflict, but I have had headache several times before with merging changes with outdated tests which caused problems for the next contributor. > > Thanks for keeping this PR alive @dengzhhu653! Thank you very much for the feedback and sorry for the late reply, I will rebase the commits. Hey @belugabehr, cloud you please take another look if have secs? The issue can be seen in long live shared Metastore client(spark, client pool), the unreleased queries would accumulate to seeing the OOM. The former patch we applied to Hive version 1.2 solved it, this patch introduces try-with-resource on the query and a sanity check on the master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 659379) Time Spent: 14h 40m (was: 14.5h) > Metastore some JDO query objects do not close properly > ------------------------------------------------------ > > Key: HIVE-23633 > URL: https://issues.apache.org/jira/browse/HIVE-23633 > Project: Hive > Issue Type: Bug > Reporter: Zhihua Deng > Assignee: Zhihua Deng > Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-23633.01.patch > > Time Spent: 14h 40m > Remaining Estimate: 0h > > After patched [HIVE-10895|https://issues.apache.org/jira/browse/HIVE-10895], > The metastore still has seen a memory leak on db resources: many > StatementImpls left unclosed. -- This message was sent by Atlassian Jira (v8.3.4#803005)