[
https://issues.apache.org/jira/browse/HIVE-25553?focusedWorklogId=658759&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-658759
]
ASF GitHub Bot logged work on HIVE-25553:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Oct/21 06:30
Start Date: 01/Oct/21 06:30
Worklog Time Spent: 10m
Work Description: warriersruthi commented on a change in pull request
#2689:
URL: https://github.com/apache/hive/pull/2689#discussion_r719975730
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/io/arrow/ArrowColumnarBatchSerDe.java
##########
@@ -185,7 +186,7 @@ private static Field toField(String name, TypeInfo
typeInfo) {
final TypeInfo keyTypeInfo = mapTypeInfo.getMapKeyTypeInfo();
final TypeInfo valueTypeInfo = mapTypeInfo.getMapValueTypeInfo();
final StructTypeInfo mapStructTypeInfo = new StructTypeInfo();
- mapStructTypeInfo.setAllStructFieldNames(Lists.newArrayList("keys",
"values"));
+ mapStructTypeInfo.setAllStructFieldNames(Lists.newArrayList("key",
"value"));
Review comment:
As the representation of map datatype in ArrowColumnarBatchSerDe is like
a list of structs data-type, where each struct element is the key-value pair of
the map.
So the structFieldNames precisely should be "key" and "value", instead of
keys and values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 658759)
Time Spent: 0.5h (was: 20m)
> Support Map data-type natively in Arrow format
> ----------------------------------------------
>
> Key: HIVE-25553
> URL: https://issues.apache.org/jira/browse/HIVE-25553
> Project: Hive
> Issue Type: Improvement
> Components: llap, Serializers/Deserializers
> Reporter: Adesh Kumar Rao
> Assignee: Adesh Kumar Rao
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Currently ArrowColumnarBatchSerDe converts map datatype as a list of structs
> data-type (where stuct is containing the key-value pair of the map). This
> causes issues when reading Map datatype using llap-ext-client as it reads a
> list of structs instead.
> HiveWarehouseConnector which uses the llap-ext-client throws exception when
> the schema (containing Map data type) is different from actual data (list of
> structs).
>
> Fixing this issue requires upgrading arrow version (where map data-type is
> supported), modifying ArrowColumnarBatchSerDe and corresponding
> Serializer/Deserializer to not use list as a workaround for map and use the
> arrow map data-type instead.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
