[
https://issues.apache.org/jira/browse/HIVE-25549?focusedWorklogId=655476&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-655476
]
ASF GitHub Bot logged work on HIVE-25549:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Sep/21 12:48
Start Date: 27/Sep/21 12:48
Worklog Time Spent: 10m
Work Description: abstractdog commented on a change in pull request #2667:
URL: https://github.com/apache/hive/pull/2667#discussion_r716657850
##########
File path: ql/src/test/queries/clientpositive/vector_windowing_row_number.q
##########
@@ -6,13 +6,14 @@ set hive.fetch.task.conversion=none;
Review comment:
please include at least "EXPLAIN VECTORIZATION DETAIL" of a query that
utilizes a CastLongToString vectorization should print partition expressions as
well I think, in the form of:
```
partitionExpressions: [ConstantVectorExpression(val 0) -> 4:int]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 655476)
Time Spent: 40m (was: 0.5h)
> Need to transient init partition expressions in vectorized PTFs
> ---------------------------------------------------------------
>
> Key: HIVE-25549
> URL: https://issues.apache.org/jira/browse/HIVE-25549
> Project: Hive
> Issue Type: Bug
> Reporter: Karen Coppage
> Assignee: Karen Coppage
> Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Sometimes the partition in a vectorized PTF needs some sort of
> transformation. For these to work the partition expression may need some
> transient variables initialized.
> Example with row_number:
> {code:java}
> create table test_rownumber (a string, b string) stored as orc;
> insert into test_rownumber values
> ('1', 'a'),
> ('2', 'b'),
> ('3', 'c'),
> ('4', 'd'),
> ('5', 'e');
> CREATE VIEW `test_rownumber_vue` AS SELECT `test_rownumber`.`a` AS
> `a`,CAST(`test_rownumber`.`a` as INT) AS `a_int`,
> `test_rownumber`.`b` as `b` from `default`.`test_rownumber`;
> set hive.vectorized.execution.enabled=true;
> select *, row_number() over(partition by a_int order by b) from
> test_rownumber_vue;
> {code}
> Output is:
> {code:java}
> +-----------------------+---------------------------+-----------------------+----------------------+
> | test_rownumber_vue.a | test_rownumber_vue.a_int | test_rownumber_vue.b |
> row_number_window_0 |
> +-----------------------+---------------------------+-----------------------+----------------------+
> | 1 | 1 | a |
> 1 |
> | 2 | 2 | b |
> 2 |
> | 3 | 3 | c |
> 3 |
> | 4 | 4 | d |
> 4 |
> | 5 | 5 | e |
> 5 |
> +-----------------------+---------------------------+-----------------------+----------------------+
> {code}
> But it should be this, because we restart the row numbering for each
> partition:
> {code:java}
> +-----------------------+---------------------------+-----------------------+----------------------+
> | test_rownumber_vue.a | test_rownumber_vue.a_int | test_rownumber_vue.b |
> row_number_window_0 |
> +-----------------------+---------------------------+-----------------------+----------------------+
> | 1 | 1 | a |
> 1 |
> | 2 | 2 | b |
> 1 |
> | 3 | 3 | c |
> 1 |
> | 4 | 4 | d |
> 1 |
> | 5 | 5 | e |
> 1 |
> +-----------------------+---------------------------+-----------------------+----------------------+
> {code}
> Explanation:
> CastStringToLong has to be executed on the partition column (a_int). Because
> CastStringToLong.integerPrimitiveCategory is not initialized, all output of
> CastStringToLong is null - so a_int is interpreted as containing null values
> only and partitioning is ignored.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
