[
https://issues.apache.org/jira/browse/HIVE-25544?focusedWorklogId=654420&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-654420
]
ASF GitHub Bot logged work on HIVE-25544:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Sep/21 09:20
Start Date: 23/Sep/21 09:20
Worklog Time Spent: 10m
Work Description: kgyrtkirk commented on a change in pull request #2662:
URL: https://github.com/apache/hive/pull/2662#discussion_r714617424
##########
File path:
common/src/java/org/apache/hadoop/hive/common/ZooKeeperHiveHelper.java
##########
@@ -0,0 +1,419 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hive.common;
Review comment:
please stop copying files inside the codebase - isn't there another way?
* is loading a common modul the other way around is also out of question?
* introduce some new common module which these modules may load
* probably placing this into the storage-api would be a bit wierd ...but
that could also avoid duplication
* other options?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 654420)
Time Spent: 20m (was: 10m)
> Remove Dependency of hive-meta-common From hive-common
> ------------------------------------------------------
>
> Key: HIVE-25544
> URL: https://issues.apache.org/jira/browse/HIVE-25544
> Project: Hive
> Issue Type: Improvement
> Reporter: David Mollitor
> Assignee: David Mollitor
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> These two things should not be linked and it means any HS2 client libraries
> pulling in hive-common library also has to pull in a ton of metastore code as
> well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
