[
https://issues.apache.org/jira/browse/HIVE-25502?focusedWorklogId=647235&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-647235
]
ASF GitHub Bot logged work on HIVE-25502:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Sep/21 08:44
Start Date: 07/Sep/21 08:44
Worklog Time Spent: 10m
Work Description: szlta commented on a change in pull request #2619:
URL: https://github.com/apache/hive/pull/2619#discussion_r703308035
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/CompactionInfo.java
##########
@@ -277,6 +277,6 @@ public static CompactionInfo
optionalCompactionInfoStructToInfo(OptionalCompacti
public void setWriteIds(Set<Long> writeIds) {
this.writeIds = writeIds;
- isSetWriteIds = true;
+ isSetWriteIds = !writeIds.isEmpty();
Review comment:
Why do we maintain 2 states for this anyway?
We could have a method instead:
public boolean isSetWriteIds() { return !writeIds.isEmpty(); }
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 647235)
Time Spent: 40m (was: 0.5h)
> Cleaner causes data loss when processing aborted txn with DP
> -------------------------------------------------------------
>
> Key: HIVE-25502
> URL: https://issues.apache.org/jira/browse/HIVE-25502
> Project: Hive
> Issue Type: Task
> Reporter: Denys Kuzmenko
> Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Steps to reproduce:
> 1) CREATE TABLE cws (b STRING) PARTITIONED BY (a INT) STORED AS ORC;
> 2) insert into cws partition (a) values (1, '1');
> update csw set b='2' where a=1;
> 3) open HiveStreamingConnection with batch size set to 1, begin txn, write
> something and abort the txn
> 4) insert into cws partition (a) values (2, '2');
> update csw set b='3' where a=2;
> 5) manually trigger the compaction and verify that data for part a=1 is gone
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
