[
https://issues.apache.org/jira/browse/HIVE-25422?focusedWorklogId=633980&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-633980
]
ASF GitHub Bot logged work on HIVE-25422:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Aug/21 07:53
Start Date: 05/Aug/21 07:53
Worklog Time Spent: 10m
Work Description: pvary commented on a change in pull request #2558:
URL: https://github.com/apache/hive/pull/2558#discussion_r683216106
##########
File path:
iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergStorageHandlerWithEngine.java
##########
@@ -20,116 +20,81 @@
package org.apache.iceberg.mr.hive;
import java.io.IOException;
-import java.math.BigDecimal;
-import java.text.SimpleDateFormat;
-import java.time.LocalDate;
-import java.time.LocalDateTime;
-import java.time.OffsetDateTime;
-import java.time.ZoneOffset;
import java.util.ArrayList;
-import java.util.Arrays;
import java.util.Collection;
-import java.util.Comparator;
-import java.util.Date;
import java.util.HashMap;
import java.util.List;
-import java.util.Locale;
import java.util.Map;
-import java.util.Properties;
import java.util.concurrent.TimeUnit;
-import java.util.stream.Collectors;
-import org.apache.hadoop.conf.Configuration;
import org.apache.hadoop.hive.common.StatsSetupConst;
import org.apache.hadoop.hive.conf.HiveConf;
-import org.apache.hadoop.hive.metastore.api.FieldSchema;
-import org.apache.hadoop.hive.metastore.api.MetaException;
-import org.apache.hadoop.hive.metastore.api.StorageDescriptor;
-import org.apache.hadoop.hive.metastore.partition.spec.PartitionSpecProxy;
import org.apache.hadoop.hive.ql.exec.mr.ExecMapper;
-import org.apache.iceberg.AssertHelpers;
import org.apache.iceberg.FileFormat;
-import org.apache.iceberg.HistoryEntry;
-import org.apache.iceberg.PartitionKey;
-import org.apache.iceberg.PartitionSpec;
import org.apache.iceberg.Schema;
import org.apache.iceberg.SnapshotSummary;
import org.apache.iceberg.Table;
-import org.apache.iceberg.TableProperties;
-import org.apache.iceberg.catalog.TableIdentifier;
-import org.apache.iceberg.data.GenericRecord;
import org.apache.iceberg.data.Record;
-import org.apache.iceberg.exceptions.NoSuchTableException;
-import org.apache.iceberg.hive.HiveSchemaUtil;
import org.apache.iceberg.hive.MetastoreUtil;
-import org.apache.iceberg.mr.Catalogs;
-import org.apache.iceberg.mr.InputFormatConfig;
import org.apache.iceberg.mr.TestHelper;
import org.apache.iceberg.relocated.com.google.common.collect.ImmutableList;
import org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap;
-import org.apache.iceberg.relocated.com.google.common.collect.Lists;
import org.apache.iceberg.types.Type;
import org.apache.iceberg.types.Types;
import org.apache.thrift.TException;
import org.junit.After;
import org.junit.AfterClass;
import org.junit.Assert;
-import org.junit.Assume;
import org.junit.Before;
import org.junit.BeforeClass;
import org.junit.Rule;
-import org.junit.Test;
import org.junit.rules.TemporaryFolder;
import org.junit.rules.Timeout;
import org.junit.runner.RunWith;
import org.junit.runners.Parameterized;
-import org.mockito.ArgumentMatchers;
-import org.mockito.MockedStatic;
-import org.mockito.Mockito;
import static org.apache.iceberg.types.Types.NestedField.optional;
import static org.apache.iceberg.types.Types.NestedField.required;
import static org.junit.runners.Parameterized.Parameter;
import static org.junit.runners.Parameterized.Parameters;
-
@RunWith(Parameterized.class)
-public class TestHiveIcebergStorageHandlerWithEngine {
+public abstract class TestHiveIcebergStorageHandlerWithEngine {
Review comment:
Should we rename this to `HiveIcebergStorageHandlerWithEngineBase` or
something, so it does not start with Test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 633980)
Time Spent: 20m (was: 10m)
> Break up TestHiveIcebergStorageHandlerWithEngine test
> -----------------------------------------------------
>
> Key: HIVE-25422
> URL: https://issues.apache.org/jira/browse/HIVE-25422
> Project: Hive
> Issue Type: Bug
> Reporter: Ádám Szita
> Assignee: Ádám Szita
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> TestHiveIcebergStorageHandlerWithEngine tests the Iceberg-Hive integration by
> running queries against Iceberg-backed tables. This is a parameterized test,
> so that each file format, each table type, and vectorization on/off scenarios
> are covered, while it is testing different functionalities too.
> This ticket will track the effort to break this test class into smaller
> chunks, as in the recent past we have observed cases where this test couldn't
> even be executed for memory/process problem reasons.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
