[ https://issues.apache.org/jira/browse/HIVE-25334?focusedWorklogId=632701&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-632701 ]
ASF GitHub Bot logged work on HIVE-25334: ----------------------------------------- Author: ASF GitHub Bot Created on: 03/Aug/21 05:03 Start Date: 03/Aug/21 05:03 Worklog Time Spent: 10m Work Description: adesh-rao commented on a change in pull request #2482: URL: https://github.com/apache/hive/pull/2482#discussion_r681435177 ########## File path: ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDF.java ########## @@ -434,10 +434,19 @@ protected void obtainTimestampConverter(ObjectInspector[] arguments, int i, case TIMESTAMP: case DATE: case TIMESTAMPLOCALTZ: + case INT: Review comment: Do these newly added datatypes for timestamp conversion have test associated with them? if not, can you add them? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 632701) Time Spent: 1h (was: 50m) > Refactor UDF CAST(<Date string> as TIMESTAMP) > --------------------------------------------- > > Key: HIVE-25334 > URL: https://issues.apache.org/jira/browse/HIVE-25334 > Project: Hive > Issue Type: Sub-task > Reporter: Ashish Sharma > Assignee: Ashish Sharma > Priority: Major > Labels: pull-request-available > Time Spent: 1h > Remaining Estimate: 0h > > Description > Refactor GenericUDFTimestamp.class > DOD > Refactor -- This message was sent by Atlassian Jira (v8.3.4#803005)