[
https://issues.apache.org/jira/browse/HIVE-25328?focusedWorklogId=632351&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-632351
]
ASF GitHub Bot logged work on HIVE-25328:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Aug/21 13:34
Start Date: 02/Aug/21 13:34
Worklog Time Spent: 10m
Work Description: pvary commented on a change in pull request #2475:
URL: https://github.com/apache/hive/pull/2475#discussion_r680976148
##########
File path:
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java
##########
@@ -309,9 +309,8 @@ public void
commitAlterTable(org.apache.hadoop.hive.metastore.api.Table hmsTable
}
@Override
- public void rollbackAlterTable(org.apache.hadoop.hive.metastore.api.Table
hmsTable, EnvironmentContext context)
- throws MetaException {
- if
(Boolean.valueOf(context.getProperties().getOrDefault(MIGRATE_HIVE_TO_ICEBERG,
"false"))) {
+ public void rollbackAlterTable(org.apache.hadoop.hive.metastore.api.Table
hmsTable, EnvironmentContext context) {
+ if
(Boolean.parseBoolean(context.getProperties().getOrDefault(MIGRATE_HIVE_TO_ICEBERG,
"false"))) {
Review comment:
What is the difference here?
```
public static Boolean valueOf(String var0) {
return parseBoolean(var0) ? TRUE : FALSE;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 632351)
Time Spent: 50m (was: 40m)
> Limit scope of REPLACE COLUMNS for Iceberg tables
> -------------------------------------------------
>
> Key: HIVE-25328
> URL: https://issues.apache.org/jira/browse/HIVE-25328
> Project: Hive
> Issue Type: Improvement
> Reporter: Marton Bod
> Assignee: Marton Bod
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Replace columns is a rather wildcard operation which can do heavy-weight
> schema changes. We would only want to allow this operation for dropping
> columns for Iceberg tables. For other changes (adding cols, renaming, type
> promotion etc.), we should use the CHANGE COLUMN command.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
