[
https://issues.apache.org/jira/browse/HIVE-25061?focusedWorklogId=631566&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-631566
]
ASF GitHub Bot logged work on HIVE-25061:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Jul/21 11:51
Start Date: 30/Jul/21 11:51
Worklog Time Spent: 10m
Work Description: pgaref commented on a change in pull request #2225:
URL: https://github.com/apache/hive/pull/2225#discussion_r623972738
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/udf/ptf/ValueBoundaryScanner.java
##########
@@ -414,16 +423,35 @@ protected int computeStartPreceding(int rowIdx,
PTFPartition p) throws HiveExcep
return r + 1;
}
else { // Use Case 5.
+ Pair<Integer, Object> start = binaryPreSearchBack(r, p, sortKey, rowVal,
amt);
+ //start again with linear search from the last point where
!isDistanceGreater was true
+ r = start.getLeft();
+ rowVal = start.getRight();
while (r >= 0 && !isDistanceGreater(sortKey, rowVal, amt) ) {
Pair<Integer, Object> stepResult = skipOrStepBack(r, p);
r = stepResult.getLeft();
rowVal = stepResult.getRight();
}
-
return r + 1;
}
}
+ private Pair<Integer, Object> binaryPreSearchBack(int r, PTFPartition p,
Object sortKey,
Review comment:
I guess existing PTF tests should cover this optimization but would be
great if we would add specific ones for cases 4 and 5 above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 631566)
Time Spent: 1h 50m (was: 1h 40m)
> PTF: Improve ValueBoundaryScanner
> ---------------------------------
>
> Key: HIVE-25061
> URL: https://issues.apache.org/jira/browse/HIVE-25061
> Project: Hive
> Issue Type: Improvement
> Reporter: László Bodor
> Assignee: László Bodor
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: Screen Shot 2021-04-27 at 1.02.37 PM.png
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> -First, I need to check whether TreeMap is really needed for our case.-
> It turned out a binary-ish search approach could help in range calculation,
> as we're searching in an ordered set of values.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
