[
https://issues.apache.org/jira/browse/HIVE-24484?focusedWorklogId=626730&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-626730
]
ASF GitHub Bot logged work on HIVE-24484:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Jul/21 15:00
Start Date: 22/Jul/21 15:00
Worklog Time Spent: 10m
Work Description: belugabehr commented on a change in pull request #1742:
URL: https://github.com/apache/hive/pull/1742#discussion_r674888734
##########
File path:
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenarios.java
##########
@@ -4117,28 +4118,33 @@ public void testAuthForNotificationAPIs() throws
Exception {
createDB(dbName, driver);
NotificationEventResponse rsp =
metaStoreClient.getNextNotification(firstEventId, 0, null);
assertEquals(1, rsp.getEventsSize());
+
// Test various scenarios
- // Remove the proxy privilege and the auth should fail (in reality the
proxy setting should not be changed on the fly)
- hconf.unset(proxySettingName);
- // Need to explicitly update ProxyUsers
- ProxyUsers.refreshSuperUserGroupsConfiguration(hconf);
- // Verify if the auth should fail
- Exception ex = null;
+ // Remove the proxy privilege by reseting proxy configuration to default
value.
+ // The auth should fail (in reality the proxy setting should not be
changed on the fly)
+ // Pretty hacky: Affects both instances of HMS
+ ProxyUsers.refreshSuperUserGroupsConfiguration();
+
try {
rsp = metaStoreClient.getNextNotification(firstEventId, 0, null);
+ Assert.fail("Get Next Nofitication should have failed due to no proxy
auth");
} catch (TException e) {
- ex = e;
Review comment:
The idea here is that it SHOULD throw an Exception. If it does not
throw an Exception from `getNextNofitication` then it will hit the
`Assert.fail`. I can add a comment to clarify that this is the expected
behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 626730)
Time Spent: 4.55h (was: 4h 23m)
> Upgrade Hadoop to 3.3.1
> -----------------------
>
> Key: HIVE-24484
> URL: https://issues.apache.org/jira/browse/HIVE-24484
> Project: Hive
> Issue Type: Improvement
> Reporter: David Mollitor
> Assignee: David Mollitor
> Priority: Major
> Labels: pull-request-available
> Time Spent: 4.55h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
