[
https://issues.apache.org/jira/browse/HIVE-21614?focusedWorklogId=623768&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-623768
]
ASF GitHub Bot logged work on HIVE-21614:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Jul/21 17:22
Start Date: 16/Jul/21 17:22
Worklog Time Spent: 10m
Work Description: hankfanchiu commented on a change in pull request #2484:
URL: https://github.com/apache/hive/pull/2484#discussion_r671413592
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
##########
@@ -4693,6 +4694,17 @@ private Table ensureGetTable(String catName, String
dbName, String tblName)
return convertToTable(ensureGetMTable(catName, dbName, tblName));
}
+ /**
+ * Conditionally alters an {@link ExpressionTree} to be compatible with
certain database products.
+ */
+ private void reconcileTreeWithDatabaseProduct(ExpressionTree tree) throws
MetaException {
+ if (sqlGenerator.getDbProduct().isDERBY()) {
Review comment:
@findepi mentioned in
https://issues.apache.org/jira/browse/HIVE-21614?focusedCommentId=16849571&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16849571
that Oracle may be implicated as well, but I have not verified.
Having this `ObjectStore#reconcileTreeWithDatabaseProduct` defined allows us
to conveniently add other databases, though, so perhaps we could revisit as
needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 623768)
Time Spent: 50m (was: 40m)
> Derby does not support CLOB comparisons
> ---------------------------------------
>
> Key: HIVE-21614
> URL: https://issues.apache.org/jira/browse/HIVE-21614
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 2.3.4, 3.0.0
> Reporter: Vlad Rozov
> Assignee: Hank Fanchiu
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> HiveMetaStoreClient.listTableNamesByFilter() with non empty filter causes
> exception with Derby DB:
> {noformat}
> Caused by: ERROR 42818: Comparisons between 'CLOB (UCS_BASIC)' and 'CLOB
> (UCS_BASIC)' are not supported. Types must be comparable. String types must
> also have matching collation. If collation does not match, a possible
> solution is to cast operands to force them to the default collation (e.g.
> SELECT tablename FROM sys.systables WHERE CAST(tablename AS VARCHAR(128)) =
> 'T1')
> at org.apache.derby.iapi.error.StandardException.newException(Unknown
> Source)
> at org.apache.derby.iapi.error.StandardException.newException(Unknown
> Source)
> at
> org.apache.derby.impl.sql.compile.BinaryComparisonOperatorNode.bindComparisonOperator(Unknown
> Source)
> at
> org.apache.derby.impl.sql.compile.BinaryComparisonOperatorNode.bindExpression(Unknown
> Source)
> at
> org.apache.derby.impl.sql.compile.BinaryOperatorNode.bindExpression(Unknown
> Source)
> at
> org.apache.derby.impl.sql.compile.BinaryLogicalOperatorNode.bindExpression(Unknown
> Source)
> at org.apache.derby.impl.sql.compile.AndNode.bindExpression(Unknown
> Source)
> at org.apache.derby.impl.sql.compile.SelectNode.bindExpressions(Unknown
> Source)
> at
> org.apache.derby.impl.sql.compile.DMLStatementNode.bindExpressions(Unknown
> Source)
> at org.apache.derby.impl.sql.compile.DMLStatementNode.bind(Unknown
> Source)
> at org.apache.derby.impl.sql.compile.CursorNode.bindStatement(Unknown
> Source)
> at org.apache.derby.impl.sql.GenericStatement.prepMinion(Unknown Source)
> at org.apache.derby.impl.sql.GenericStatement.prepare(Unknown Source)
> at
> org.apache.derby.impl.sql.conn.GenericLanguageConnectionContext.prepareInternalStatement(Unknown
> Source)
> ... 42 more
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
