[ 
https://issues.apache.org/jira/browse/HIVE-25288?focusedWorklogId=622916&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-622916
 ]

ASF GitHub Bot logged work on HIVE-25288:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 15/Jul/21 09:01
            Start Date: 15/Jul/21 09:01
    Worklog Time Spent: 10m 
      Work Description: pvary commented on a change in pull request #2476:
URL: https://github.com/apache/hive/pull/2476#discussion_r670274361



##########
File path: 
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorOnTezTest.java
##########
@@ -85,6 +86,8 @@ public void setup() throws Exception {
     hiveConf.setVar(HiveConf.ConfVars.METASTOREWAREHOUSE, TEST_WAREHOUSE_DIR);
     hiveConf.setVar(HiveConf.ConfVars.HIVEINPUTFORMAT, 
HiveInputFormat.class.getName());
     hiveConf.setVar(HiveConf.ConfVars.HIVEFETCHTASKCONVERSION, "none");
+    hiveConf.set(MetastoreConf.ConfVars.TXN_OPENTXN_TIMEOUT.getVarname(), 
"2000");

Review comment:
       We should use the code below to set MetastoreConf values to handle 
migration between HiveConf, MetastoreConf:
   ```
       MetastoreConf.setVar(hiveConf, 
MetastoreConf.ConfVars.TXN_OPENTXN_TIMEOUT, "2000");
   ```
   
   This is not too relevant here since this is only test code, but I prefer to 
stick to the standard way everywhere, so the next contributor will learn 
correctly.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 622916)
    Time Spent: 20m  (was: 10m)

> Fix TestMmCompactorOnTez
> ------------------------
>
>                 Key: HIVE-25288
>                 URL: https://issues.apache.org/jira/browse/HIVE-25288
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Zoltan Haindrich
>            Assignee: Denys Kuzmenko
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> http://ci.hive.apache.org/job/hive-flaky-check/240/



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to