[
https://issues.apache.org/jira/browse/HIVE-25137?focusedWorklogId=622351&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-622351
]
ASF GitHub Bot logged work on HIVE-25137:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Jul/21 03:14
Start Date: 14/Jul/21 03:14
Worklog Time Spent: 10m
Work Description: pkumarsinha commented on a change in pull request #2457:
URL: https://github.com/apache/hive/pull/2457#discussion_r669248010
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java
##########
@@ -10447,4 +10447,22 @@ public void drop_package(DropPackageRequest request)
throws MetaException {
endFunction("drop_package", ex == null, ex);
}
}
+
+ @Override
+ public List<WriteEventInfo>
get_all_write_event_info(GetAllWriteEventInfoRequest request)
+ throws MetaException {
+ startFunction("get_all_write_event_info");
+ Exception ex = null;
+ try {
+ List<WriteEventInfo> writeEventInfoList =
+ getMS().getAllWriteEventInfo(request.getTxnId(),
request.getDbName(), request.getTableName());
+ return writeEventInfoList == null ? Collections.emptyList() :
writeEventInfoList;
+ } catch (Exception e) {
+ LOG.error("Caught exception", e);
+ ex = e;
Review comment:
While existing method also has it, I wonder what do you get by this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 622351)
Time Spent: 20m (was: 10m)
> getAllWriteEventInfo should go through the HMS client instead of using
> RawStore directly
> ----------------------------------------------------------------------------------------
>
> Key: HIVE-25137
> URL: https://issues.apache.org/jira/browse/HIVE-25137
> Project: Hive
> Issue Type: Improvement
> Reporter: Pratyush Madhukar
> Assignee: Yu-Wen Lai
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> {code:java}
> private List<WriteEventInfo> getAllWriteEventInfo(Context withinContext)
> throws Exception {
> String contextDbName =
> StringUtils.normalizeIdentifier(withinContext.replScope.getDbName());
> RawStore rawStore =
> HiveMetaStore.HMSHandler.getMSForConf(withinContext.hiveConf);
> List<WriteEventInfo> writeEventInfoList
> = rawStore.getAllWriteEventInfo(eventMessage.getTxnId(),
> contextDbName, null);
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
