[
https://issues.apache.org/jira/browse/HIVE-25314?focusedWorklogId=621686&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-621686
]
ASF GitHub Bot logged work on HIVE-25314:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Jul/21 20:06
Start Date: 12/Jul/21 20:06
Worklog Time Spent: 10m
Work Description: lcspinter commented on a change in pull request #2458:
URL: https://github.com/apache/hive/pull/2458#discussion_r667892099
##########
File path:
iceberg/iceberg-handler/src/test/queries/positive/show_create_iceberg_table.q
##########
@@ -0,0 +1,7 @@
+DROP TABLE IF EXISTS ice_t;
+CREATE EXTERNAL TABLE ice_t (i int, s string, ts timestamp, d date) STORED BY
ICEBERG;
+SHOW CREATE TABLE ice_t;
Review comment:
In this case, the partition spec will be among the table properties.
I've added a new test case to cover this as well.
##########
File path:
iceberg/iceberg-handler/src/test/queries/positive/show_create_iceberg_table.q
##########
@@ -0,0 +1,7 @@
+DROP TABLE IF EXISTS ice_t;
+CREATE EXTERNAL TABLE ice_t (i int, s string, ts timestamp, d date) STORED BY
ICEBERG;
+SHOW CREATE TABLE ice_t;
Review comment:
Sorry, my bad, I've slipped over the `PARTITIONED BY` part. This will
be the output:
`CREATE TABLE tbl (a int, b int) PARTITIONED BY SPEC(c) STORED BY ICEBERG`
##########
File path:
iceberg/iceberg-handler/src/test/queries/positive/show_create_iceberg_table.q
##########
@@ -0,0 +1,7 @@
+DROP TABLE IF EXISTS ice_t;
+CREATE EXTERNAL TABLE ice_t (i int, s string, ts timestamp, d date) STORED BY
ICEBERG;
+SHOW CREATE TABLE ice_t;
Review comment:
My example was incorrect :), but the actual output will contain the
additional column.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 621686)
Time Spent: 1h 40m (was: 1.5h)
> Implement SHOW CREATE TABLE command for Iceberg tables
> ------------------------------------------------------
>
> Key: HIVE-25314
> URL: https://issues.apache.org/jira/browse/HIVE-25314
> Project: Hive
> Issue Type: Improvement
> Reporter: László Pintér
> Assignee: László Pintér
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Implement SHOW CREATE TABLE, including the partitioning info as well in the
> output (even though the HMS table is unpartitioned). That would probably
> require loading the Iceberg table to acquire the partitioning information.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
