[
https://issues.apache.org/jira/browse/HIVE-25074?focusedWorklogId=621212&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-621212
]
ASF GitHub Bot logged work on HIVE-25074:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Jul/21 00:09
Start Date: 10/Jul/21 00:09
Worklog Time Spent: 10m
Work Description: github-actions[bot] commented on pull request #2232:
URL: https://github.com/apache/hive/pull/2232#issuecomment-877517638
This pull request has been automatically marked as stale because it has not
had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the d...@hive.apache.org list if the patch is in
need of reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 621212)
Time Spent: 20m (was: 10m)
> Remove Metastore flushCache usage
> ---------------------------------
>
> Key: HIVE-25074
> URL: https://issues.apache.org/jira/browse/HIVE-25074
> Project: Hive
> Issue Type: Improvement
> Components: Metastore, Standalone Metastore
> Affects Versions: 4.0.0
> Reporter: Miklos Szurap
> Assignee: Zoltan Chovan
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The "flushCache" in HiveMetaStore with the ObjectStore implementation is
> currently a NOOP:
> {code:java}
> public void flushCache() {
> // NOP as there's no caching
> } {code}
> The HBaseStore (HBaseReadWrite) had some logic in it, however it has been
> removed in HIVE-17234.
> As I see the calls are going like this:
> HiveMetaStoreClient.flushCache() -> CachedStore.flushCache() ->
> ObjectStore.flushCache()
> There are significant amount of calls (about 10% of all calls) made from the
> client to the server - to do nothing. We could spare the call to the server
> completely, including getting a DB connection which can take 1+ seconds under
> high load scenarios slowing down Hive queries unnecessarily.
> Can we:
> # Deprecate the RawStore.flushCache (if there are other implementations)
> # Deprecate the HiveMetaStoreClient.flushCache()
> # Do the NOOP on the client side in HiveMetaStoreClient.flushCache() (while
> it is not removed in a next version)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
