[
https://issues.apache.org/jira/browse/HIVE-25272?focusedWorklogId=614500&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-614500
]
ASF GitHub Bot logged work on HIVE-25272:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Jun/21 13:16
Start Date: 24/Jun/21 13:16
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on a change in pull request #2413:
URL: https://github.com/apache/hive/pull/2413#discussion_r657937252
##########
File path:
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenariosAcidTables.java
##########
@@ -176,6 +177,41 @@ public void
testReplOperationsNotCapturedInNotificationLog() throws Throwable {
assert lastEventId == currentEventId;
}
+ @Test
+ public void testReadOperationsNotCapturedInNotificationLog() throws
Throwable {
+ //Perform empty bootstrap dump and load
+ String dbName = testName.getMethodName();
+ String replDbName = "replicated_" + testName.getMethodName();
+ try {
+ primary.run("CREATE DATABASE " + dbName + " WITH DBPROPERTIES ( '" +
+ SOURCE_OF_REPLICATION + "' = '1,2,3')");
+ primary.hiveConf.set("hive.txn.readonly.enabled", "true");
+ primary.run("CREATE TABLE " + dbName + ".t1 (id int)");
+ primary.dump(dbName);
+ replica.run("REPL LOAD " + dbName + " INTO " + replDbName);
+ //Perform empty incremental dump and load so that all db level
properties are altered.
+ primary.dump(dbName);
+ replica.run("REPL LOAD " + dbName + " INTO " + replDbName);
+ primary.run("INSERT INTO " + dbName + ".t1 VALUES(1)");
+ long lastEventId = primary.getCurrentNotificationEventId().getEventId();
+ primary.run("USE " + dbName);
+ primary.run("DESCRIBE DATABASE " + dbName);
+ primary.run("DESCRIBE "+ dbName + ".t1");
+ primary.run("SELECT * FROM " + dbName + ".t1");
+ primary.run("SHOW TABLES " + dbName);
+ primary.run("SHOW TABLE EXTENDED LIKE 't1'");
+ primary.run("SHOW TBLPROPERTIES t1");
+ primary.run("EXPLAIN SELECT * from " + dbName + ".t1");
+ primary.run("SHOW LOCKS");
+ primary.run("EXPLAIN SHOW LOCKS");
Review comment:
Could you please add test case for 'EXPLAIN LOCKS \<query\>' that is
widely used?
```
EXPLAIN LOCKS UPDATE target SET b = 1 WHERE p IN (SELECT t.q1 FROM source t
WHERE t.a1=5)'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 614500)
Time Spent: 3h (was: 2h 50m)
> READ transactions are getting logged in NOTIFICATION LOG
> --------------------------------------------------------
>
> Key: HIVE-25272
> URL: https://issues.apache.org/jira/browse/HIVE-25272
> Project: Hive
> Issue Type: Bug
> Reporter: Pravin Sinha
> Assignee: Pravin Sinha
> Priority: Major
> Labels: pull-request-available
> Time Spent: 3h
> Remaining Estimate: 0h
>
> While READ transactions are already skipped from getting logged in
> NOTIFICATION logs, few are still getting logged. Need to skip those
> transactions as well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
