[ 
https://issues.apache.org/jira/browse/HIVE-24945?focusedWorklogId=613788&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-613788
 ]

ASF GitHub Bot logged work on HIVE-24945:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 23/Jun/21 02:57
            Start Date: 23/Jun/21 02:57
    Worklog Time Spent: 10m 
      Work Description: ramesh0201 commented on a change in pull request #2278:
URL: https://github.com/apache/hive/pull/2278#discussion_r656722407



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/plan/VectorPTFDesc.java
##########
@@ -172,8 +179,8 @@ public VectorPTFDesc() {
 
   // We provide this public method to help EXPLAIN VECTORIZATION show the 
evaluator classes.
   public static VectorPTFEvaluatorBase getEvaluator(SupportedFunctionType 
functionType,
-      boolean isDistinct, WindowFrameDef windowFrameDef, Type columnVectorType,
-      VectorExpression inputVectorExpression, int outputColumnNum) {
+      List<ExprNodeDesc> evaluatorParameters, boolean isDistinct, 
WindowFrameDef windowFrameDef,

Review comment:
       I think we dont need the evaluatorParameters argument passed to this 
function




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 613788)
    Time Spent: 0.5h  (was: 20m)

> PTF: Support vectorization for lead/lag functions
> -------------------------------------------------
>
>                 Key: HIVE-24945
>                 URL: https://issues.apache.org/jira/browse/HIVE-24945
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: László Bodor
>            Assignee: László Bodor
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to