[
https://issues.apache.org/jira/browse/HIVE-25204?focusedWorklogId=611385&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-611385
]
ASF GitHub Bot logged work on HIVE-25204:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Jun/21 15:07
Start Date: 15/Jun/21 15:07
Worklog Time Spent: 10m
Work Description: maheshk114 commented on a change in pull request #2365:
URL: https://github.com/apache/hive/pull/2365#discussion_r651886691
##########
File path:
hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/listener/DbNotificationListener.java
##########
@@ -905,25 +909,32 @@ public void
onUpdatePartitionColumnStat(UpdatePartitionColumnStatEvent updatePar
}
@Override
- public void
onUpdatePartitionColumnStatDirectSql(UpdatePartitionColumnStatEvent
updatePartColStatEvent,
- Connection dbConn,
SQLGenerator sqlGenerator)
+ public void
onUpdatePartitionColumnStatInBatch(UpdatePartitionColumnStatEventBatch
updatePartColStatEventBatch,
Review comment:
Yes ..for normal listeners we can not change as they may be expecting
the data in that way. The change is done only for transactional listeners
(DBNotification listener is a transactional listener). The notification for
transactional listeners are done inside the direct sql method as it has to be
within same transaction. For normal listeners we need not have them in the same
transaction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 611385)
Time Spent: 1h (was: 50m)
> Reduce overhead of adding notification log for update partition column
> statistics
> ---------------------------------------------------------------------------------
>
> Key: HIVE-25204
> URL: https://issues.apache.org/jira/browse/HIVE-25204
> Project: Hive
> Issue Type: Sub-task
> Components: Hive, HiveServer2
> Reporter: mahesh kumar behera
> Assignee: mahesh kumar behera
> Priority: Major
> Labels: perfomance, pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> The notification logs for partition column statistics can be optimised by
> adding them in batch. In the current implementation its done one by one
> causing multiple sql execution in the backend RDBMS. These SQL executions can
> be batched to reduce the execution time.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
