[
https://issues.apache.org/jira/browse/HIVE-24748?focusedWorklogId=611057&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-611057
]
ASF GitHub Bot logged work on HIVE-24748:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Jun/21 00:10
Start Date: 15/Jun/21 00:10
Worklog Time Spent: 10m
Work Description: github-actions[bot] closed pull request #1953:
URL: https://github.com/apache/hive/pull/1953
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 611057)
Time Spent: 0.5h (was: 20m)
> The result of TimestampWritableV2.toString() is wrong when year is larger
> than 9999.
> ------------------------------------------------------------------------------------
>
> Key: HIVE-24748
> URL: https://issues.apache.org/jira/browse/HIVE-24748
> Project: Hive
> Issue Type: Bug
> Components: Serializers/Deserializers
> Affects Versions: All Versions
> Environment: Master branch
> Reporter: Qiang.Kang
> Assignee: Qiang.Kang
> Priority: Critical
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Hi, I found that `TimestampWritableV2.toString()` can be wrong when year is
> larger than 9999. Here is what I get:
> - test code:
> {code:java}
> // code placeholder
> @Test
> public void testTimestampWritableV2toString() {
> TimestampWritableV2 timestampWritableV2 = new TimestampWritableV2(
> Timestamp.valueOf("10001-01-01 01:01:23"));
>
> assertEquals("+10001-01-01 01:01:23", timestampWritableV2.toString());
> }{code}
> - output:
> {code:java}
> // code placeholder
> org.junit.ComparisonFailure:
> Expected :+10001-01-01 01:01:23
> Actual :+10001-01-01 01:01:2323
> {code}
> The patch below removes some 'wrong' code in
> `TimestampWritableV2.toString()`, for the reason that the length of
> `org.apache.hadoop.hive.common.type.Timestamp#toString` can be larger than
> 19, even its nano-of-second is zero.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
