[
https://issues.apache.org/jira/browse/HIVE-23633?focusedWorklogId=609266&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-609266
]
ASF GitHub Bot logged work on HIVE-23633:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jun/21 17:13
Start Date: 09/Jun/21 17:13
Worklog Time Spent: 10m
Work Description: belugabehr commented on a change in pull request #2344:
URL: https://github.com/apache/hive/pull/2344#discussion_r648509685
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java
##########
@@ -914,6 +914,7 @@ private boolean isViewTable(String catName, String dbName,
String tblName) throw
long queryTime = doTrace ? System.nanoTime() : 0;
MetastoreDirectSqlUtils.timingTrace(doTrace, queryText, start, queryTime);
if (sqlResult.isEmpty()) {
+ query.closeAll();
return Collections.emptyList(); // no partitions, bail early.
}
Review comment:
Can you just remove this entire block? This will allow for a single
return statement at the bottom and also allows the cleanup to happen.
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java
##########
@@ -1453,6 +1454,7 @@ public ColumnStatistics getTableStats(final String
catName, final String dbName,
};
List<Object[]> list = Batchable.runBatched(batchSize, colNames, b);
if (list.isEmpty()) {
+ b.closeAllQueries();
return null;
}
Review comment:
Same here....
```java
List<Object[]> list = Batchable.runBatched(batchSize, colNames, b);
final ColumnStatistics result;
if (list.isEmpty()) {
result = null;
} else {
ColumnStatisticsDesc csd = new ColumnStatisticsDesc(true, dbName,
tableName);
csd.setCatName(catName);
result = makeColumnStats(list, csd, 0, engine);
}
b.closeAllQueries();
return result;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 609266)
Time Spent: 4h 50m (was: 4h 40m)
> Metastore some JDO query objects do not close properly
> ------------------------------------------------------
>
> Key: HIVE-23633
> URL: https://issues.apache.org/jira/browse/HIVE-23633
> Project: Hive
> Issue Type: Bug
> Reporter: Zhihua Deng
> Assignee: Zhihua Deng
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-23633.01.patch
>
> Time Spent: 4h 50m
> Remaining Estimate: 0h
>
> After patched [HIVE-10895|https://issues.apache.org/jira/browse/HIVE-10895],
> The metastore still has seen a memory leak on db resources: many
> StatementImpls left unclosed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
