[ https://issues.apache.org/jira/browse/HIVE-25154?focusedWorklogId=608215&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-608215 ]
ASF GitHub Bot logged work on HIVE-25154: ----------------------------------------- Author: ASF GitHub Bot Created on: 08/Jun/21 02:04 Start Date: 08/Jun/21 02:04 Worklog Time Spent: 10m Work Description: pkumarsinha commented on a change in pull request #2311: URL: https://github.com/apache/hive/pull/2311#discussion_r647056770 ########## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/PartitionManagementTask.java ########## @@ -169,7 +168,7 @@ public void run() { // this always runs in 'sync' mode where partitions can be added and dropped MsckInfo msckInfo = new MsckInfo(table.getCatName(), table.getDbName(), table.getTableName(), null, null, true, true, true, retentionSeconds); - executorService.submit(new MsckThread(msckInfo, msckConf, qualifiedTableName, countDownLatch)); + executorService.submit(new MsckThread(msckInfo, msckConf, qualifiedTableName, countDownLatch, msc)); Review comment: Sorry, looks like I missed to notice this change earlier. Sharing HMS client across threads might not be good idea. If all threads makes the call at the same time, the results might get mixed up. It would be better to use separate client for each of them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 608215) Time Spent: 4.5h (was: 4h 20m) > Disable StatsUpdaterThread and PartitionManagementTask for db that is being > failoved over. > ------------------------------------------------------------------------------------------ > > Key: HIVE-25154 > URL: https://issues.apache.org/jira/browse/HIVE-25154 > Project: Hive > Issue Type: Improvement > Reporter: Haymant Mangla > Assignee: Haymant Mangla > Priority: Major > Labels: pull-request-available > Time Spent: 4.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)