[ https://issues.apache.org/jira/browse/HIVE-25194?focusedWorklogId=607024&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-607024 ]
ASF GitHub Bot logged work on HIVE-25194: ----------------------------------------- Author: ASF GitHub Bot Created on: 04/Jun/21 11:45 Start Date: 04/Jun/21 11:45 Worklog Time Spent: 10m Work Description: marton-bod commented on a change in pull request #2348: URL: https://github.com/apache/hive/pull/2348#discussion_r645506912 ########## File path: parser/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g ########## @@ -1971,10 +1971,12 @@ tableFileFormat -> ^(TOK_TABLEFILEFORMAT $inFmt $outFmt $inDriver? $outDriver?) | KW_STORED KW_BY storageHandler=StringLiteral (KW_WITH KW_SERDEPROPERTIES serdeprops=tableProperties)? - -> ^(TOK_STORAGEHANDLER $storageHandler $serdeprops?) + (KW_STORED KW_AS fileformat=identifier)? Review comment: Does this mean we will now enable STORED BY and STORED AS in the same query for all storage handlers, like Kudu, Kafka, etc? Do we expect them to break as a result, e.g. if saying something like `stored by kudu stored as orc`? In addition, I guess we should update the Hive language manual too after this change to signify that stored as/stored by are not mutually exclusive. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 607024) Time Spent: 1h 20m (was: 1h 10m) > Add support for STORED AS ORC/PARQUET/AVRO for Iceberg > ------------------------------------------------------ > > Key: HIVE-25194 > URL: https://issues.apache.org/jira/browse/HIVE-25194 > Project: Hive > Issue Type: New Feature > Reporter: László Pintér > Assignee: László Pintér > Priority: Major > Labels: pull-request-available > Time Spent: 1h 20m > Remaining Estimate: 0h > > Currently we have to specify the fileformat in TBLPROPERTIES during Iceberg > create table statements. > The ideal syntax would be: > CREATE TABLE tbl STORED BY ICEBERG STORED AS ORC ... > One complication is that currently stored by and stored as are not permitted > within the same query, so that needs to be amended. -- This message was sent by Atlassian Jira (v8.3.4#803005)