[ 
https://issues.apache.org/jira/browse/HIVE-25161?focusedWorklogId=602879&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-602879
 ]

ASF GitHub Bot logged work on HIVE-25161:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 27/May/21 11:03
            Start Date: 27/May/21 11:03
    Worklog Time Spent: 10m 
      Work Description: marton-bod commented on a change in pull request #2316:
URL: https://github.com/apache/hive/pull/2316#discussion_r640519810



##########
File path: 
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java
##########
@@ -328,6 +345,7 @@ static void overlayTableProperties(Configuration 
configuration, TableDesc tableD
     map.put(InputFormatConfig.TABLE_IDENTIFIER, 
props.getProperty(Catalogs.NAME));
     map.put(InputFormatConfig.TABLE_LOCATION, table.location());
     map.put(InputFormatConfig.TABLE_SCHEMA, schemaJson);
+    props.put(InputFormatConfig.PARTITION_SPEC, 
PartitionSpecParser.toJson(table.spec()));

Review comment:
       Yes, you're right. There's actually an open upstream Iceberg PR for 
extracting out the serialization stuff from here: 
https://github.com/apache/iceberg/pull/2598. Let's wait for that to be merged 
then we can backport it to Hive as well.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 602879)
    Time Spent: 3.5h  (was: 3h 20m)

> Implement CTAS for partitioned Iceberg tables
> ---------------------------------------------
>
>                 Key: HIVE-25161
>                 URL: https://issues.apache.org/jira/browse/HIVE-25161
>             Project: Hive
>          Issue Type: New Feature
>            Reporter: Marton Bod
>            Assignee: Marton Bod
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 3.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to