[ 
https://issues.apache.org/jira/browse/HIVE-25102?focusedWorklogId=602217&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-602217
 ]

ASF GitHub Bot logged work on HIVE-25102:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 26/May/21 09:50
            Start Date: 26/May/21 09:50
    Worklog Time Spent: 10m 
      Work Description: pvary commented on a change in pull request #2261:
URL: https://github.com/apache/hive/pull/2261#discussion_r639572145



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/Driver.java
##########
@@ -213,7 +216,14 @@ private void runInternal(String command, boolean 
alreadyCompiled) throws Command
         releaseResources();
       }
 
+      if (SessionState.get() != null) {
+        // Clean up every resource object stored in the query state
+        driverContext.getQueryState().removeResources();

Review comment:
       The QueryState in the DriverContext should be removed as well when the 
query finishes. Otherwise we still would have a leaked QueryState which is a 
memory leak itself. So this only makes the leak smaller, but does not fix it 
(if we have any)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 602217)
    Time Spent: 8h 10m  (was: 8h)

> Cache Iceberg table objects within same query
> ---------------------------------------------
>
>                 Key: HIVE-25102
>                 URL: https://issues.apache.org/jira/browse/HIVE-25102
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: László Pintér
>            Assignee: László Pintér
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 8h 10m
>  Remaining Estimate: 0h
>
> We run Catalogs.loadTable(configuration, props) plenty of times which is 
> costly.
> We should:
>  - Cache it maybe even globally based on the queryId
>  - Make sure that the query uses one snapshot during the whole execution of a 
> single query



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to