[
https://issues.apache.org/jira/browse/HIVE-25161?focusedWorklogId=602167&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-602167
]
ASF GitHub Bot logged work on HIVE-25161:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 26/May/21 07:49
Start Date: 26/May/21 07:49
Worklog Time Spent: 10m
Work Description: pvary commented on a change in pull request #2316:
URL: https://github.com/apache/hive/pull/2316#discussion_r639481964
##########
File path:
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java
##########
@@ -328,6 +345,7 @@ static void overlayTableProperties(Configuration
configuration, TableDesc tableD
map.put(InputFormatConfig.TABLE_IDENTIFIER,
props.getProperty(Catalogs.NAME));
map.put(InputFormatConfig.TABLE_LOCATION, table.location());
map.put(InputFormatConfig.TABLE_SCHEMA, schemaJson);
+ props.put(InputFormatConfig.PARTITION_SPEC,
PartitionSpecParser.toJson(table.spec()));
Review comment:
This is again something which is not by the spec. What happens if this
change is not propagated? Changing props might not be allowed - even though it
is working now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 602167)
Time Spent: 1h (was: 50m)
> Implement CTAS for partitioned Iceberg tables
> ---------------------------------------------
>
> Key: HIVE-25161
> URL: https://issues.apache.org/jira/browse/HIVE-25161
> Project: Hive
> Issue Type: New Feature
> Reporter: Marton Bod
> Assignee: Marton Bod
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
