[ https://issues.apache.org/jira/browse/HIVE-25128?focusedWorklogId=600877&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-600877 ]
ASF GitHub Bot logged work on HIVE-25128: ----------------------------------------- Author: ASF GitHub Bot Created on: 22/May/21 17:45 Start Date: 22/May/21 17:45 Worklog Time Spent: 10m Work Description: belugabehr commented on pull request #2291: URL: https://github.com/apache/hive/pull/2291#issuecomment-846441655 @miklosgergely This one is an important foundation change based on my discussions in HIVE-25126, but the details for this particular PR are found in HIVE-25128. Please let me know what you think. Thanks!!! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 600877) Time Spent: 1h 10m (was: 1h) > Remove Thrift Exceptions From RawStore alterCatalog > --------------------------------------------------- > > Key: HIVE-25128 > URL: https://issues.apache.org/jira/browse/HIVE-25128 > Project: Hive > Issue Type: Sub-task > Reporter: David Mollitor > Assignee: David Mollitor > Priority: Major > Labels: pull-request-available > Time Spent: 1h 10m > Remaining Estimate: 0h > > {code:java|title=RawStore.java} > /** > * Alter an existing catalog. Only description and location can be > changed, and the change of > * location is for internal use only. > * @param catName name of the catalog to alter. > * @param cat new version of the catalog. > * @throws MetaException something went wrong, usually in the database. > * @throws InvalidOperationException attempt to change something about the > catalog that is not > * changeable, like the name. > */ > void alterCatalog(String catName, Catalog cat) throws MetaException, > InvalidOperationException; > {code} > Please check out parent task [HIVE-25126] for the motivation here, but I > would like to remove all Thrift-based Exceptions from the {{RawStore}} > interface to include MetaException and InvalidOperationException. These > should be replaced with something that is specific to Hive and not tied to > the RPC layer. > I propose instead introducing RuntimeExceptions called > HiveMetaRuntimeException and sub-class HiveMetaDataAccessException to replace > these. > HiveMetaDataAccessException = Unable to load data from underlying data store > HiveMetaRuntimeException = Generic exception for something that was thrown by > the RawStore but not specifically handled -- This message was sent by Atlassian Jira (v8.3.4#803005)