[ 
https://issues.apache.org/jira/browse/HIVE-24663?focusedWorklogId=600284&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-600284
 ]

ASF GitHub Bot logged work on HIVE-24663:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 21/May/21 10:56
            Start Date: 21/May/21 10:56
    Worklog Time Spent: 10m 
      Work Description: pvary commented on a change in pull request #2266:
URL: https://github.com/apache/hive/pull/2266#discussion_r636827308



##########
File path: 
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/info/desc/DescTableOperation.java
##########
@@ -213,11 +214,14 @@ private void getColumnDataColPathSpecified(Table table, 
Partition part, List<Fie
       }
     } else {
       List<String> partitions = new ArrayList<String>();
-      partitions.add(part.getName());
+      // The partition name is converted to lowercase before generating the 
stats. So we should use the same

Review comment:
       Isn't this an issue?
   
   I mean the `key=US` an `key=us` should be a different partition key, so 
modifying the values could cause issues later




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 600284)
    Time Spent: 1h 40m  (was: 1.5h)

> Batch process in ColStatsProcessor for partitions.
> --------------------------------------------------
>
>                 Key: HIVE-24663
>                 URL: https://issues.apache.org/jira/browse/HIVE-24663
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Rajesh Balamohan
>            Assignee: mahesh kumar behera
>            Priority: Major
>              Labels: performance, pull-request-available
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> When large number of partitions (>20K) are processed, ColStatsProcessor runs 
> into DB issues. 
> {{ db.setPartitionColumnStatistics(request);}} gets stuck for hours together 
> and in some cases postgres stops processing. 
> It would be good to introduce small batches for stats gathering in 
> ColStatsProcessor instead of bulk update.
> Ref: 
> https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/stats/ColStatsProcessor.java#L181
> https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/stats/ColStatsProcessor.java#L199



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to