[
https://issues.apache.org/jira/browse/HIVE-25079?focusedWorklogId=599830&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-599830
]
ASF GitHub Bot logged work on HIVE-25079:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 20/May/21 14:28
Start Date: 20/May/21 14:28
Worklog Time Spent: 10m
Work Description: klcopp commented on a change in pull request #2281:
URL: https://github.com/apache/hive/pull/2281#discussion_r636158595
##########
File path:
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSMetricsListener.java
##########
@@ -86,4 +92,24 @@ public void onAddPartition(AddPartitionEvent partitionEvent)
throws MetaExceptio
Metrics.getOrCreateGauge(MetricsConstants.TOTAL_PARTITIONS).incrementAndGet();
createdParts.inc();
}
+
+ @Override
+ public void onAllocWriteId(AllocWriteIdEvent allocWriteIdEvent, Connection
dbConn, SQLGenerator sqlGenerator) throws MetaException {
+ Table table = getTable(allocWriteIdEvent);
Review comment:
Ok. Maybe add some JavaDoc about this so nobody else gets confused...
but otherwise LGTM then :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 599830)
Time Spent: 1h 10m (was: 1h)
> Create new metric about number of writes to tables with manually disabled
> compaction
> ------------------------------------------------------------------------------------
>
> Key: HIVE-25079
> URL: https://issues.apache.org/jira/browse/HIVE-25079
> Project: Hive
> Issue Type: Bug
> Reporter: Antal Sinkovits
> Assignee: Antal Sinkovits
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Create a new metric that measures the number of writes tables that has
> compaction turned off manually. It does not matter if the write is committed
> or aborted (both are bad...)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
