[ https://issues.apache.org/jira/browse/HIVE-25085?focusedWorklogId=596960&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-596960 ]
ASF GitHub Bot logged work on HIVE-25085: ----------------------------------------- Author: ASF GitHub Bot Created on: 14/May/21 22:21 Start Date: 14/May/21 22:21 Worklog Time Spent: 10m Work Description: kishendas commented on pull request #2238: URL: https://github.com/apache/hive/pull/2238#issuecomment-841530958 How was this patch tested? We ran 10 beeline clients concurrently over a span of 6 hours to reproduce the original problem. With the fix, we were no longer able to reproduce. Since the testing was manual, is it possible to write a test with multiple clients/sessions which tests the logic that you have modified ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 596960) Time Spent: 1h 20m (was: 1h 10m) > MetaStore Clients are being shared across different sessions > ------------------------------------------------------------ > > Key: HIVE-25085 > URL: https://issues.apache.org/jira/browse/HIVE-25085 > Project: Hive > Issue Type: Bug > Components: HiveServer2 > Reporter: Steve Carlin > Priority: Major > Labels: pull-request-available > Time Spent: 1h 20m > Remaining Estimate: 0h > > The Hive object (and the underlying MetaStoreClient object) seems to be > getting shared across different sessions. While most operations work, there > can be occasional glitches. > One such noted glitch is that when session 1 ends, it closes the connection. > If session 2 then tries an operation, the first try will fail. Normally this > can proceed because the RetryingMetaStoreClient will re-establish a new > connection, but in some operations, the retrying logic will not kick in (by > design). > It seems there was an attempt to fix this issue in HIVE-20682. However, this > implementation seems to be flawed. The HiveSessionImpl object creates a Hive > object and makes sure all thread queries belonging to the same session will > run with the same Hive object. The flaw is that the initial Hive Object > within HiveSessionImpl is created in thread local storage. The thread being > run at that moment is not session specific. It belongs to a thread pool that > happens to be handling this specific session. > -- This message was sent by Atlassian Jira (v8.3.4#803005)