[ 
https://issues.apache.org/jira/browse/HIVE-23931?focusedWorklogId=596607&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-596607
 ]

ASF GitHub Bot logged work on HIVE-23931:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 14/May/21 11:47
            Start Date: 14/May/21 11:47
    Worklog Time Spent: 10m 
      Work Description: kgyrtkirk commented on a change in pull request #2211:
URL: https://github.com/apache/hive/pull/2211#discussion_r632473124



##########
File path: 
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift
##########
@@ -701,6 +705,8 @@ struct UniqueConstraintsRequest {
   1: required string catName,
   2: required string db_name,
   3: required string tbl_name,
+  4: optional string validWriteIdList,
+  5: optional i64 tableId=-1

Review comment:
       I wonder if a common object to reference a table might be handy ; these 
5 fields are copied to a bunch of requests/responses - having a common object 
might make it easier to work with them




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 596607)
    Time Spent: 1h  (was: 50m)

> Send ValidWriteIdList and tableId to get_*_constraints HMS APIs
> ---------------------------------------------------------------
>
>                 Key: HIVE-23931
>                 URL: https://issues.apache.org/jira/browse/HIVE-23931
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Kishen Das
>            Assignee: Ashish Sharma
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> Send ValidWriteIdList and tableId to get_*_constraints HMS APIs. This would 
> be required in order to decide whether the response should be served from the 
> Cache or backing DB.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to