[
https://issues.apache.org/jira/browse/HIVE-25075?focusedWorklogId=592006&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-592006
]
ASF GitHub Bot logged work on HIVE-25075:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 02/May/21 14:06
Start Date: 02/May/21 14:06
Worklog Time Spent: 10m
Work Description: rbalamohan commented on a change in pull request #2234:
URL: https://github.com/apache/hive/pull/2234#discussion_r624700779
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
##########
@@ -3202,7 +3202,7 @@ public void loadTable(Path loadPath, String tableName,
LoadFileType loadFileType
//for fullAcid we don't want to delete any files even for OVERWRITE
see HIVE-14988/HIVE-17361
boolean isSkipTrash = MetaStoreUtils.isSkipTrash(tbl.getParameters());
boolean needRecycle = !tbl.isTemporary()
- &&
ReplChangeManager.shouldEnableCm(Hive.get().getDatabase(tbl.getDbName()),
tbl.getTTable());
Review comment:
Fixed in recent commit. Fine with the invocation for PartitionIterable
as "new PartitionIterable(Hive.get()" (since it could have pointed earlier to
diff db).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 592006)
Time Spent: 0.5h (was: 20m)
> Hive::loadPartitionInternal establishes HMS connection for every partition
> for external tables
> ----------------------------------------------------------------------------------------------
>
> Key: HIVE-25075
> URL: https://issues.apache.org/jira/browse/HIVE-25075
> Project: Hive
> Issue Type: Improvement
> Reporter: Rajesh Balamohan
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java#L2522
> {code}
> boolean needRecycle = !tbl.isTemporary()
> &&
> ReplChangeManager.shouldEnableCm(Hive.get().getDatabase(tbl.getDbName()),
> tbl.getTTable());
> {code}
> Hive.get() breaks the current connection with HMS. Due to this, for external
> table partition loads, it establishes HMS connection for partition.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
