[
https://issues.apache.org/jira/browse/HIVE-24974?focusedWorklogId=587318&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-587318
]
ASF GitHub Bot logged work on HIVE-24974:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Apr/21 15:35
Start Date: 22/Apr/21 15:35
Worklog Time Spent: 10m
Work Description: klcopp commented on a change in pull request #2148:
URL: https://github.com/apache/hive/pull/2148#discussion_r618509889
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/metrics/DeltaFilesMetricReporter.java
##########
@@ -45,32 +45,46 @@
import org.slf4j.LoggerFactory;
import java.io.IOException;
-import java.util.Comparator;
+import java.util.*;
Review comment:
Nit: I think it's best to import classes one-by-one
##########
File path: common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
##########
@@ -3013,14 +3013,15 @@ private static void
populateLlapDaemonVarsSet(Set<String> llapDaemonVarsSetLocal
new TimeValidator(TimeUnit.SECONDS),
"Reporting period for ACID metrics in seconds."),
HIVE_TXN_ACID_METRICS_DELTA_NUM_THRESHOLD("hive.txn.acid.metrics.delta.num.threshold",
100,
- "The minimum number of active delta files a table/partition must be
included in the ACID metrics report."),
+ "he minimum number of active delta files a table/partition must have
in order to be included in the ACID metrics report."),
Review comment:
Nit: spelling
##########
File path: common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
##########
@@ -3013,14 +3013,15 @@ private static void
populateLlapDaemonVarsSet(Set<String> llapDaemonVarsSetLocal
new TimeValidator(TimeUnit.SECONDS),
"Reporting period for ACID metrics in seconds."),
HIVE_TXN_ACID_METRICS_DELTA_NUM_THRESHOLD("hive.txn.acid.metrics.delta.num.threshold",
100,
- "The minimum number of active delta files a table/partition must be
included in the ACID metrics report."),
+ "he minimum number of active delta files a table/partition must have
in order to be included in the ACID metrics report."),
HIVE_TXN_ACID_METRICS_OBSOLETE_DELTA_NUM_THRESHOLD("hive.txn.acid.metrics.obsolete.delta.num.threshold",
100,
- "The minimum number of obsolete delta files a table/partition must be
included in the ACID metrics report."),
+ "he minimum number of obsolete delta files a table/partition must have
in order to be included in the ACID metrics report."),
Review comment:
Nit: spelling
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 587318)
Time Spent: 2h 20m (was: 2h 10m)
> Create new metrics about the number of delta files in the ACID table
> --------------------------------------------------------------------
>
> Key: HIVE-24974
> URL: https://issues.apache.org/jira/browse/HIVE-24974
> Project: Hive
> Issue Type: Sub-task
> Reporter: Denys Kuzmenko
> Assignee: Denys Kuzmenko
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> 2 metrics should be collected by each table/partition that exceeds some limit.
> * Number of used deltas
> * Number of obsolete deltas
> Both of them should be collected in AcidUtils.getAcidstate call, and only be
> published if they reached a configurable threshold (to not pollute metrics)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
